Form: fix get item by path (T1311534) #31492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the Form component's itemOption method when retrieving items by path where multiple items share the same name or caption (T1311534). The fix ensures path-based lookups correctly traverse nested groups and return the intended item rather than the first matching name.
Key changes:
- Fixed the
_getFieldPartsmethod to correctly reverse the path array after splitting - Added validation in
_getItemByFieldPathto ensure the path node matches before retrieving nested items - Changed return types from
falsetonullfor consistency with TypeScript conventions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.form/form.tests.js | Added test case verifying itemOption retrieves correct items by path when duplicates exist |
| packages/devextreme/js/__internal/ui/form/form.utils.ts | Changed return type from false to null for consistency |
| packages/devextreme/js/__internal/ui/form/form.ts | Fixed path parsing logic and added path validation to prevent incorrect item matching |
anna-shakhova
force-pushed
the
25_2__T1311534
branch
from
b5480bc to
a1c242f
Compare
anna-shakhova
force-pushed
the
25_2__T1311534
branch
from
a1c242f to
6a6a1c7
Compare
anna-shakhova
force-pushed
the
25_2__T1311534
branch
from
6a6a1c7 to
ad9448a
Compare
anna-shakhova
force-pushed
the
25_2__T1311534
branch
from
ad9448a to
69fa561
Compare
packages/devextreme/testing/tests/DevExpress.ui.widgets.form/form.label.tests.js
Outdated
Show resolved
Hide resolved
anna-shakhova
force-pushed
the
25_2__T1311534
branch
2 times, most recently
from
3e07deb to
482e249
Compare
anna-shakhova
force-pushed
the
25_2__T1311534
branch
from
482e249 to
dd122f0
Compare
EugeniyKiyashko
approved these changes
Oct 30, 2025
anna-shakhova
force-pushed
the
25_2__T1311534
branch
from
dd122f0 to
9a2732e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.